Concordium / concordium-desktop-wallet

Desktop wallet for the Concordium blockchain. For Windows, macOS and Linux.
Apache License 2.0
2 stars 3 forks source link

We inform the user that commission rates are changeable which is incorrect #242

Closed mh-concordium closed 2 years ago

mh-concordium commented 2 years ago

Bug Description Commission rates are fixed and the text in pool settings is written as its configurable.

Steps to Reproduce Try to add baker through DW. Pool settings are presented as changeable.

Expected Result Text should be adjusted with the non configurable commission rates.

Actual Result

image

Versions

soerenbf commented 2 years ago

Yes, we should handle this better. I guess as long as it's possible to change one of the values, the text is OK. Maybe a more suitable and educating description could be:

"When you open your baker as a pool, you earn commissions of stake delegated to your pool from other accounts:"

Is it not implicit from the slider component that you can adjust the value if it's there?

@jens-concordium, @dg-concordium?

jens-concordium commented 2 years ago

I like that approach, @soerenbf!

mh-concordium commented 2 years ago

"Register a baker as a pool" is maybe better since we have this kind of referencing in wallet.

image

soerenbf commented 2 years ago

"Register a baker as a pool" is maybe better since we have this kind of referencing in wallet.

image

Well, I think that communicates that there is a separate flow for registering as something else than a pool? I think "Register as a baker" would be more accurate; you register some baker configuration and keys to your existing account.

The description of the option to open or close the pool is best handled in the flow, in my opinion.

mh-concordium commented 2 years ago

OK.

soerenbf commented 2 years ago

@jens-concordium, @dg-concordium, are you OK with this as well, or is there another way to make it even clearer what the action does (referring to the register baker discussion here)?