Removed percentage encoding of proof url - Githubissues

Concordium / concordium-mysomeid

0 stars 0 forks source link

Removed percentage encoding of proof url #128

Closed krismoe42 closed 1 year ago

krismoe42 commented 1 year ago

Purpose

Fix issue experienced by some linkedin profiles with a "=" or "/" character in the decryption key of the proof url.

Changes

Removed percentage encoding of proof url and added checks to make sure that proof url is valid.

Checklist

[ ] My code follows the style of this project.
[ ] The code compiles without warnings.
[ ] I have performed a self-review of the changes.
[ ] I have documented my code, in particular the intent of the hard-to-understand areas.
[ ] (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
[ ] I accept the above linked CLA.

krismoe42 commented 1 year ago

I have now added some tests ( we didnt have support for it before but we need it anyways so I think its about time to start writing tests to make the implementation more reliable ).