search

Concordium / concordium-node

The main concordium node implementation.
GNU Affero General Public License v3.0
45 stars 22 forks source link

Node is attempting to connect to banned peers #1039

Open mh-concordium opened 11 months ago

mh-concordium commented 11 months ago

Bug Description After a peer is banned, looking at the log indicates that the node tries to connect to the banned peer.

Steps to Reproduce

  1. Look at connected peers on the node.
  2. Ban a connected peer concordium-client raw BanNode 54.217.153.40.
  3. Restart the node and observe the log (make sure clearing banned nodes at the restart is not enabled).

Expected Result The node should not attempt to connect to banned peers.

Actual Result Looking at the logs indicates that the node keeps trying to connect to the banned peer. Attempting to connect to 54.217.153.40:8888 (499472e35a3740b3).

Versions

abizjak commented 11 months ago

So I think this is just a logging issue (in the sense that logging is not ideal). That line in the logs should be followed by

Refusing to connect to a banned IP

if I understand correctly.

It's not entirely obvious in what direction to change the logging though since the information that it is "attempting" to connect is useful.