Closed Bargsteen closed 2 years ago
@abizjak Could you take a look at this to determine whether we can close the task (while keeping the branch alive, of course ;) )
I browsed through it now. The only thing I noticed is that ContractEvent still has the old hex schema, and it also does not specify max length.
If you can fix that then this can be closed from my perspective.
I've addressed the comments. I will close this issue now.
As stated in the description, the idea is to keep the branch living alongside main
because deriving the schemas is slow and makes the editor support slow (because rustanalyzer
becomes slow).
We derive the JSON schema by using schemars on the types in the concordium-rust-sdk repository (branch: https://github.com/Concordium/concordium-rust-sdk/tree/derive-schema). Deriving the JSON is slow and causes rustanalyzer to be slow and sometimes crash, so we do not want to merge the branch. Instead, it should remain a separate branch which we will then merge main into when relevant.
There are two parts of this task: