search

Concordium / concordium-node

The main concordium node implementation.
GNU Affero General Public License v3.0
45 stars 22 forks source link

New Consensus: Tree State Transaction Handling <> Code Duplication #768

Open MilkywayPirate opened 1 year ago

MilkywayPirate commented 1 year ago

With the new introduced tree state for the new consensus protocol a great deal of duplicated code (which basically shares the same implementations used in the persistent tree state) has been introduced with respect to transaction handling.

See https://github.com/Concordium/concordium-node/pull/708

This is not ideal and incurs a non insignificant maintenance burden and so we should refactor this in order to make the future maintenance more approachable.

MilkywayPirate commented 1 year ago

As pointed out in this review: https://github.com/Concordium/concordium-node/pull/749#discussion_r1133742534 we should see whether we can refactor this bit so that it can be shared with consensusv0.