search

Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

Schema as object #199

Closed sasho-axellero closed 1 year ago

sasho-axellero commented 1 year ago

The Schema is handled differently in the Android Wallet than in the Browser Wallet. In the Browser Wallet it's received as Object and in the Android wallet as a String. This update addresses that and is backwards compatible with the String Schema.

The Mobile Wallet Library (mobile_wallet_lib-release.aar) is also updated to support the new Schema as an Object format.

bisgardo commented 1 year ago

Are the Gradle changes relevant for the schema stuff? If not, please do them in a separate PR.

github-actions[bot] commented 1 year ago
File Coverage [3.46%] :x:
Schema.kt 100% :green_apple:
ParamsDeserializer.kt 86.09% :green_apple:
Params.kt 33.33% :x:
WalletConnectViewModel.kt 0% :x:
WalletConnectService.kt 0% :x:
CryptoLibraryReal.kt 0% :x:
ParameterToJsonInput.kt 0% :x:
Total Project Coverage 0.38% :x:
github-actions[bot] commented 1 year ago
File Coverage [3.46%] :x:
Schema.kt 100% :green_apple:
ParamsDeserializer.kt 86.09% :green_apple:
Params.kt 33.33% :x:
WalletConnectViewModel.kt 0% :x:
WalletConnectService.kt 0% :x:
CryptoLibraryReal.kt 0% :x:
ParameterToJsonInput.kt 0% :x:
Total Project Coverage 0.38% :x:
github-actions[bot] commented 1 year ago
File Coverage [5.59%] :x:
Schema.kt 100% :green_apple:
NullableTypeAdapterFactory.kt 91.67% :green_apple:
ParamsDeserializer.kt 87.27% :green_apple:
Params.kt 28.92% :x:
WalletConnectViewModel.kt 0% :x:
WalletConnectService.kt 0% :x:
CryptoLibraryReal.kt 0% :x:
ParameterToJsonInput.kt 0% :x:
Total Project Coverage 0.49% :x:
github-actions[bot] commented 1 year ago
File Coverage [5.59%] :x:
Schema.kt 100% :green_apple:
NullableTypeAdapterFactory.kt 91.67% :green_apple:
ParamsDeserializer.kt 87.27% :green_apple:
Params.kt 28.92% :x:
WalletConnectViewModel.kt 0% :x:
WalletConnectService.kt 0% :x:
CryptoLibraryReal.kt 0% :x:
ParameterToJsonInput.kt 0% :x:
Total Project Coverage 0.49% :x:
bisgardo commented 1 year ago

Please add an explanation in the PR description of why mobile_wallet_lib-release/mobile_wallet_lib-release.aar is changed.

This is not done.

sasho-axellero commented 1 year ago

Please add an explanation in the PR description of why mobile_wallet_lib-release/mobile_wallet_lib-release.aar is changed.

This is not done.

Sorry, I missed that. Added.

github-actions[bot] commented 1 year ago
File Coverage [5.79%] :x:
Schema.kt 100% :green_apple:
NullableTypeAdapterFactory.kt 92.31% :green_apple:
ParamsDeserializer.kt 87.27% :green_apple:
Params.kt 28.92% :x:
WalletConnectViewModel.kt 0% :x:
WalletConnectService.kt 0% :x:
CryptoLibraryReal.kt 0% :x:
ParameterToJsonInput.kt 0% :x:
Total Project Coverage 0.49% :x: