search

Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

CI: Upload AAB files instead of APKs #215

Closed bisgardo closed 3 months ago

bisgardo commented 1 year ago

Purpose

Ensure that we build the files suitable for release on Play Store.

Changes

Make the "Build and upload" workflow build/upload AAB bundle files instead of APKs.

It's not clear to me how the build is supposed to be signed. The workflow doesn't have access to any signing certificates of credentials, so the produced bundles are not signed with anything that is trusted.

github-actions[bot] commented 1 year ago

There is no coverage information present for the Files changed

Total Project Coverage 0.85% :x:
bisgardo commented 1 year ago

Ran test workflow https://github.com/Concordium/concordium-reference-wallet-android/actions/runs/4758365182.

sasho-axellero commented 1 year ago

It's not clear to me how the build is supposed to be signed. The workflow doesn't have access to any signing certificates of credentials, so the produced bundles are not signed with anything that is trusted.

https://proandroiddev.com/how-to-securely-build-and-sign-your-android-app-with-github-actions-ad5323452ce I or Jens need to send you the key-store file and the credentials.