Implement new T&C solution on Android

czerwix commented 1 year ago

Purpose

Implement new T&C solution on Android detailed description can be found in issue CBW-911.

Changes

Added new Onboarding Activity with jetpack navigation and KoinDI. introduced new TermsFragment that will handle terms accepted by the client. added a number of todos to keep track of further work required.

Below sample usage of new changes introduced: concordium_terms_initial.webm concordium_terms_update.webm

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
[x] I accept the above-linked CLA.

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

bisgardo commented 1 year ago

Would it be possible to add tests for at least the basic flow? Like https://github.com/Concordium/concordium-reference-wallet-ios/pull/310/files#diff-b0bca1c18e26af94fc0acfe89180d8ade699ea2cd48b36183f93235b02f1ada7.

czerwix commented 1 year ago

I don't know if there's something wrong with my setup, but I still get the wall of text display on a fresh install. That shouldn't happen right?

yes, fixed now.

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
IntroTermsActivity.kt	0%	:x:
MainViewModel.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
IntroTermsActivity.kt	0%	:x:
MainViewModel.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
IntroTermsActivity.kt	0%	:x:
MainViewModel.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

github-actions[bot] commented 1 year ago

File	Coverage [0%]	:x:
TermsAndConditionsItem.kt	0%	:x:
App.kt	0%	:x:
BackendEventObserver.kt	0%	:x:
BackendObserver.kt	0%	:x:
EventObserver.kt	0%	:x:
TermsAndConditionsViewModel.kt	0%	:x:
TermsAndConditionsFragment.kt	0%	:x:
OnboardingRepository.kt	0%	:x:
BaseBindingFragment.kt	0%	:x:
DelegationRegisterAmountActivity.kt	0%	:x:
OnboardingActivity.kt	0%	:x:
OnboardingModule.kt	0%	:x:
ModuleLoader.kt	0%	:x:
AppModule.kt	0%	:x:
RecipientListViewModel.kt	0%	:x:
TermsAndConditionsDto.kt	0%	:x:
IntroTermsActivity.kt	0%	:x:
MainViewModel.kt	0%	:x:
MainActivity.kt	0%	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerRegisterAmountActivity.kt	0%	:x:
SharedPreferencesDataSourceImpl.kt	0%	:x:
IdentityProviderListViewModel.kt	0%	:x:

Total Project Coverage	0.84%	:x:

Concordium / concordium-reference-wallet-android