Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

[CBW-987] Fixed error message shown to the user on backend error in delegation Update #227

Closed czerwix closed 1 year ago

czerwix commented 1 year ago

Purpose

Fixed error message is shown to the user on backend error in delegation Update. Updated balance calculation logic in DelegationActivity to account for delegated/shielded amounts

Checklist

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
BackendErrorHandler.kt 0% :x:
Total Project Coverage 0.83% :x:
bisgardo commented 1 year ago

Please update the PR title/description to also cover the changes in DelegationRegisterAmountActivity.kt. Right now they only reflect the error message change.

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
DelegationRegisterAmountActivity.kt 0% :x:
BackendErrorHandler.kt 0% :x:
Total Project Coverage 0.83% :x:
github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
DelegationRegisterAmountActivity.kt 0% :x:
BackendErrorHandler.kt 0% :x:
Total Project Coverage 0.83% :x:
github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
Total Project Coverage 0.83% :x:
github-actions[bot] commented 1 year ago
File Coverage [1.37%] :x:
StakeAmountInputValidator.kt 19.42% :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
BakerRegisterAmountActivity.kt 0% :x:
Account.kt 0% :x:
Total Project Coverage 0.91% :x:
github-actions[bot] commented 1 year ago
File Coverage [1.37%] :x:
StakeAmountInputValidator.kt 19.42% :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
BakerRegisterAmountActivity.kt 0% :x:
Account.kt 0% :x:
Total Project Coverage 0.91% :x:
github-actions[bot] commented 1 year ago
File Coverage [1.37%] :x:
StakeAmountInputValidator.kt 19.42% :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
BakerRegisterAmountActivity.kt 0% :x:
Account.kt 0% :x:
Total Project Coverage 0.91% :x:
github-actions[bot] commented 1 year ago
File Coverage [1.37%] :x:
StakeAmountInputValidator.kt 19.42% :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
BakerRegisterAmountActivity.kt 0% :x:
Account.kt 0% :x:
Total Project Coverage 0.91% :x:
github-actions[bot] commented 1 year ago
File Coverage [1.37%] :x:
StakeAmountInputValidator.kt 19.42% :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
BakerRegisterAmountActivity.kt 0% :x:
Account.kt 0% :x:
Total Project Coverage 0.91% :x:
github-actions[bot] commented 1 year ago
File Coverage [1.37%] :x:
StakeAmountInputValidator.kt 19.42% :x:
DelegationRegisterAmountActivity.kt 0% :x:
DelegationBakerViewModel.kt 0% :x:
BackendErrorHandler.kt 0% :x:
BakerRegisterAmountActivity.kt 0% :x:
Account.kt 0% :x:
Total Project Coverage 0.91% :x: