Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

Fix not renaming account from the settings #235

Closed Radiokot closed 12 months ago

Radiokot commented 1 year ago

Purpose

This PR fixes not renaming account from the settings in some cases. The bug appears when you stay at the settings screen for too long, so the AccountUpdater triggered from the account details screen overwrites the changes in the database.

Changes

Checklist

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0

Radiokot commented 1 year ago

I think I'm wasting your CI time because of not having enough permissions in the repo

czerwix commented 1 year ago

I think I'm wasting your CI time because of not having enough permissions in the repo Yes, I need to fix it. once I get all cis2 changes CI is first on priority on list :D

TouHouNo commented 12 months ago

big thanks for your contributions. unfortunatly I cant edit/modify your PR-s. In order not to bother you more i have collected your contributions in 1 PR and rebased it on the latest codebase :D https://github.com/Concordium/concordium-reference-wallet-android/pull/307

I'll close this PR