Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

Remove electionDifficulty from chain parameters. #256

Closed abizjak closed 1 year ago

abizjak commented 1 year ago

Purpose

Election difficulty is no longer present in P6.

The JSON parsing done by the wallet turns out to just set it to null if it is not present, but that is "works by accident" solution.

Since the election difficulty is not actually used by the wallet, this PR removes it alltogether.

Checklist

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
ChainParameters.kt 0% :x:
Total Project Coverage 0.95% :x:
czerwix commented 1 year ago

looks good, please update changelog.md

abizjak commented 1 year ago

looks good, please update changelog.md

It is updated now.

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
ChainParameters.kt 0% :x:
Total Project Coverage 0.95% :x:
github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
ChainParameters.kt 0% :x:
Total Project Coverage 0.95% :x:
czerwix commented 1 year ago

looks good, please update changelog.md

It is updated now. image please add these changed under ###Changes in [Unreleased] part

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
ChainParameters.kt 0% :x:
Total Project Coverage 0.94% :x:
github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
ChainParameters.kt 0% :x:
Total Project Coverage 0.94% :x: