Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

The wallet allows sending funds to non-existing accounts #265

Closed Radiokot closed 1 year ago

Radiokot commented 1 year ago

Bug Description It is possible to send non-shielded funds or CIS-2 tokens to an account which doesn't exist or is from another network.

Steps to Reproduce

  1. Open account details screen
  2. Click Send
  3. Enter CCD or token amount and paste the address of the account from another network (mainnet when using testnet or vice versa)
  4. Click Send funds
  5. On the receipt screen, click Send funds

Expected Result An error saying that this account does not exist is shown. The transaction is not sent, no costs are spent.

Actual Result The transaction is sent. Fee amount is wasted. CIS-2 token amount is wasted.

Versions

Radiokot commented 1 year ago

@czerwix

ali-concordium commented 1 year ago

@Radiokot Thank you. We are currently working on a patch release, which will be released in 2 weeks. We will include a fix for this.

czerwix commented 1 year ago

hi, the issue is addressed in https://github.com/Concordium/concordium-reference-wallet-android/pull/289