Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

[cbw 1004] seed extract #279

Closed czerwix closed 1 year ago

czerwix commented 1 year ago

Purpose

Add the ability to extract or show wallet seed phrase to the client.

When a new client enrolment occurs and a wallet is being generated save the Seed phrase to save the location and allow for the extraction of it through wallet settings.

Save the successful seed phrase input by the user when recovering a wallet and the option to extract it through wallet settings.

Changes

Added necessary repository/Fragment and ViewModel

Screen_recording_20230515_171757.webm

Checklist

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
App.kt 0% :x:
StringExtension.kt 0% :x:
SettingsActivity.kt 0% :x:
PassPhraseRevealedFragment.kt 0% :x:
PassPhraseInputFragment.kt 0% :x:
SetupWalletActivity.kt 0% :x:
PassPhraseViewModel.kt 0% :x:
BaseBindingFragment.kt 0% :x:
PassPhraseModule.kt 0% :x:
AuthenticationRepository.kt 0% :x:
SharedPreferencesDataSourceImpl.kt 0% :x:
ExportSeedPhraseActivity.kt 0% :x:
ExportPassPhraseFragment.kt 0% :x:
PassPhraseRecoverViewModel.kt 0% :x:
RecoverWalletActivity.kt 0% :x:
PassPhraseRecoverInputFragment.kt 0% :x:
ExportPassPhraseViewModel.kt 0% :x:
Total Project Coverage 0.94% :x:
orhoj commented 1 year ago

If I install a fresh wallet and choose "Recover wallet", then the wallet crashes.

github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
App.kt 0% :x:
StringExtension.kt 0% :x:
SettingsActivity.kt 0% :x:
PassPhraseRevealedFragment.kt 0% :x:
PassPhraseInputFragment.kt 0% :x:
SetupWalletActivity.kt 0% :x:
PassPhraseViewModel.kt 0% :x:
BaseBindingFragment.kt 0% :x:
PassPhraseModule.kt 0% :x:
AuthenticationRepository.kt 0% :x:
SharedPreferencesDataSourceImpl.kt 0% :x:
ExportSeedPhraseActivity.kt 0% :x:
ExportPassPhraseFragment.kt 0% :x:
PassPhraseRecoverViewModel.kt 0% :x:
RecoverWalletActivity.kt 0% :x:
PassPhraseRecoverInputFragment.kt 0% :x:
ExportPassPhraseViewModel.kt 0% :x:
Total Project Coverage 0.93% :x:
github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
App.kt 0% :x:
StringExtension.kt 0% :x:
SettingsActivity.kt 0% :x:
PassPhraseRevealedFragment.kt 0% :x:
PassPhraseInputFragment.kt 0% :x:
SetupWalletActivity.kt 0% :x:
PassPhraseViewModel.kt 0% :x:
BaseBindingFragment.kt 0% :x:
PassPhraseModule.kt 0% :x:
AuthenticationRepository.kt 0% :x:
SharedPreferencesDataSourceImpl.kt 0% :x:
ExportSeedPhraseActivity.kt 0% :x:
ExportPassPhraseFragment.kt 0% :x:
PassPhraseRecoverViewModel.kt 0% :x:
RecoverWalletActivity.kt 0% :x:
PassPhraseRecoverInputFragment.kt 0% :x:
ExportPassPhraseViewModel.kt 0% :x:
Total Project Coverage 0.93% :x:
github-actions[bot] commented 1 year ago
File Coverage [0%] :x:
App.kt 0% :x:
StringExtension.kt 0% :x:
SettingsActivity.kt 0% :x:
PassPhraseRevealedFragment.kt 0% :x:
PassPhraseInputFragment.kt 0% :x:
SetupWalletActivity.kt 0% :x:
PassPhraseViewModel.kt 0% :x:
BaseBindingFragment.kt 0% :x:
PassPhraseModule.kt 0% :x:
AuthenticationRepository.kt 0% :x:
SharedPreferencesDataSourceImpl.kt 0% :x:
ExportSeedPhraseActivity.kt 0% :x:
ExportPassPhraseFragment.kt 0% :x:
PassPhraseRecoverViewModel.kt 0% :x:
RecoverWalletActivity.kt 0% :x:
PassPhraseRecoverInputFragment.kt 0% :x:
ExportPassPhraseViewModel.kt 0% :x:
Total Project Coverage 0.93% :x: