[CBW-1039 and CBW-1043] fixed Simple CCD formatting issues and comple…

Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain

Apache License 2.0

12 stars 2 forks source link

[CBW-1039 and CBW-1043] fixed Simple CCD formatting issues and comple… #281

Closed czerwix closed 1 year ago

czerwix commented 1 year ago

Changes

fixes [CBW-1039]Decoding/displaying parameters in the Android wallet (via walletConnect) and fixes [CBW-1043]Simple CCD Transfer not working in Android wallet

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
[x] I accept the above linked CLA.

ghost commented 1 year ago

Can you help me understand why this is fixing 1044?

Name of the PR mentions 1044 and 1043 but the branch name is 1039.

Can you update PR description such that it specifies which bugs it fixes, what the issues was and what was done to solve it. Then it is easier for me to review.

agentmic487 commented 1 year ago

Can you help me understand why this is fixing 1044?

Name of the PR mentions 1044 and 1043 but the branch name is 1039.

Can you update PR description such that it specifies which bugs it fixes, what the issues was and what was done to solve it. Then it is easier for me to review.

Hi mate, are you still having this issue or got it solved? If not you can get in touch with me so we can both get it solved together because a lot of people have come with same complain and it work for them i believe we can solve this together...Don't wait to say hi

github-actions[bot] commented 1 year ago

File	Coverage [2.29%]	:x:
ParamsDeserializer.kt	82.35%	:green_apple:
Schema.kt	30.19%	:x:
Params.kt	25%	:x:
WalletConnectViewModel.kt	0%	:x:
WalletConnectTransactionFragment.kt	0%	:x:
CryptoLibraryReal.kt	0%	:x:
Payload.kt	0%	:x:
SendTokenViewModel.kt	0%	:x:

Total Project Coverage	0.94%	:x:

github-actions[bot] commented 1 year ago

File	Coverage [1.87%]	:x:
ParamsDeserializer.kt	82.35%	:green_apple:
Schema.kt	30.19%	:x:
Params.kt	25%	:x:
WalletConnectViewModel.kt	0%	:x:
WalletConnectService.kt	0%	:x:
WalletConnectTransactionFragment.kt	0%	:x:
CryptoLibraryReal.kt	0%	:x:
Payload.kt	0%	:x:
SendTokenViewModel.kt	0%	:x:

Total Project Coverage	0.94%	:x: