search

Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

WalletConnect: Fix parsing of "broken" schema format #304

Closed bisgardo closed 1 year ago

bisgardo commented 1 year ago

The format was emitted by mistake from the a previous version of the client side library @concordium/wallet-connectors. The library has been fixed but the wallets retain support for it for backwards compatibility.

The Wallet accepted the format but passed it indiscriminately to the crypto library without doing the appropriate conversion. This resulted in the library call failing without any error being surfaced to the user. Instead the parameters are just not presented on the approval screen. With this commit the conversion is performed right after the schema is parsed to handle it correctly. Ideally error handling should be improved to avoid misleading the user, but as the app is being deprecated, it may not be worth the effort.

github-actions[bot] commented 1 year ago
File Coverage [56.42%] :x:
ParamsDeserializer.kt 56.42% :x:
Total Project Coverage 0.93% :x:
github-actions[bot] commented 1 year ago
File Coverage [56.42%] :x:
ParamsDeserializer.kt 56.42% :x:
Total Project Coverage 0.93% :x:
bisgardo commented 1 year ago

please add a summary to changelog

done

github-actions[bot] commented 1 year ago
File Coverage [56.42%] :x:
ParamsDeserializer.kt 56.42% :x:
Total Project Coverage 0.93% :x: