Fix crash on commission rates input - Githubissues

Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain

Apache License 2.0

12 stars 2 forks source link

Fix crash on commission rates input #329

Closed Radiokot closed 7 months ago

Radiokot commented 7 months ago

Purpose

Fix inability to edit validator pool commission rates in locales with comma decimal separator due to crashing.

Changes

Simplify setting of input suffix by making it a companion TextView – TextWatcher approach doesn't go well with decimal input
Make rate inputs AmountEditTexts to properly handle decimal input
Do not rewrite input values on failed parsing
Use locale-aware number format for percentages
Remove obsolete extensions

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

github-actions[bot] commented 7 months ago

File	Coverage [0%]	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerPoolSettingsActivity.kt	0%	:x:

Total Project Coverage	1.01%	:x:

github-actions[bot] commented 7 months ago

File	Coverage [0%]	:x:
BakerRegistrationConfirmationActivity.kt	0%	:x:
BakerPoolSettingsActivity.kt	0%	:x:

Total Project Coverage	1.01%	:x: