Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain
Apache License 2.0
12 stars 2 forks source link

Scheduled transfers with memo have cut off text for amounts with many decimal places #34

Closed concordium-cl closed 2 years ago

concordium-cl commented 3 years ago

Bug Description

Scheduled transfers with memo have cut off text for amounts with many decimal places, e.g. on sender account as the fee usually has many decimal places. This happens both in transfer list and in the transfer details when clicking on a transfer in transfer list, so the full text will never been shown anywhere.

See https://github.com/Concordium/concordium-reference-wallet-ios/issues/69 for same issue on iOS.

Steps to Reproduce

Expected Result Text is fully shown, at least in transfer details.

Actual Result Text is cut off.

Versions

jensvesti commented 3 years ago

@concordium-cl image This is not super trivial. It has grown slowly over time and is rather complex. These are the various views involved. It has to look nice in lists, when icons are present or absent if texts/amounts are long, and in lists texts should be truncated with “…” but not in details screen. If we want to fix this, we need to rethink how it should look in various states, and what views take precedence over others (eg amount is more important than account name). There are other issues with margins and minor odd behaviour as well.

My proposal is to refactor this part after we agree on how it should look in various states. I will provide an estimate separately.

eb-concordium commented 2 years ago

Tested on Android 9, app version 1.0.13. Text is still displayed with "..." under Transaction Details. But it seems to have been fixed on iOS: https://github.com/Concordium/concordium-reference-wallet-ios/issues/69 Can something similar be done here?

jens-concordium commented 2 years ago

The name of the transaction now splits into two lines in the details if it the name is long, as intended. Verified in 1.0.14.