Transaction messages -> Transaction memos in notification title

Concordium / concordium-reference-wallet-android

Reference Android wallet for the Concordium blockchain

Apache License 2.0

12 stars 2 forks source link

Transaction messages -> Transaction memos in notification title #48

Closed jens-concordium closed 2 years ago

jens-concordium commented 2 years ago

Description When the user adds a memo to a transaction, a small warning is shown to let the user know that the memo is public. The title of the warning says "Transaction messages" while it should say "Transaction memos".

Steps to Reproduce

Start making a transaction
Add memo.
Notice the warning.

Expected Result

Title says "Transaction memos"

Actual Result

Title says "Transaction messages"

Versions

Software Version: 1.0.14
OS: Android

concordium-cl commented 2 years ago

While fixing the above, please also correct "any memo sent with a transaction is permanent".

jens-concordium commented 2 years ago

@jensvesti

Title is changed in 1.0.15, but the plural error in the text from Caro's comment is not. Is it worth another build to get the text updated, @concordium-cl?

jens-concordium commented 2 years ago

We decided that it was not worth it to make a new build. We can maybe fix this in a later verison.