Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain
Apache License 2.0
11 stars 10 forks source link

Toggle should be "pressed down" when the tab is selected #220

Closed mh-concordium closed 2 years ago

mh-concordium commented 2 years ago

Bug Description Selected tab is highlighted while it should be grayed (pressed down) when the tab is active. This should be teh same as implemented on Android version 2.0.1 (71)

Steps to Reproduce Show shielded balance.

Expected Result Shielded balance view should appear and the tab should look as it was pressed down. It should look the same as on Android MW.

Actual Result It looks the opposite compared to implementation on Android MW.

Image: toggling

Versions

ruxandra-constantinescu commented 2 years ago

@mh-concordium Current iOS implementation is aligned with the wireframes. @jens-concordium Can you clear this?

image
jens-concordium commented 2 years ago

@ruxandra-constantinescu, yep, sorry, I forgot to mention that at the status. The Android version had accidentally been implemented "the wrong way around", but after testing it, it turned out to actually seem more clear that way. So we ended up deciding to go with that way instead.

mh-concordium commented 2 years ago

Shielded balance is previewed but the transfer details are not changed accordingly. If you select burger menu -> show shielded balance

Result: Shielded balance tab is previewed with correct shielded balance but transaction details are still from the initial account. Video:

https://user-images.githubusercontent.com/98821384/158248479-88c851be-01a4-4b31-9b34-cf0e64cde273.mp4

Expected result: transfer details should follow the balance tab accordingly.

Versions

concordium-cl commented 2 years ago

Verified in CCD app 2.0.0 (38), iPhone 11, iOS 15.1.