search

Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain
Apache License 2.0
11 stars 10 forks source link

release 1.5.0 #388

Closed ramakser closed 7 months ago

ramakser commented 8 months ago

Release 1.5.0 relates fixes

Fixes:

CBW-1640 Shield CCDs with the new account

CBW - 1638 Add proper CIS-2 token image preview: add thumbnail and display images due to docs

CBW-1478 Fix CIS-2 token local db persistency

CBW-1626 Fix restaking logic, in case when user want update options without changing stake amount

CBW-1643 Fix contract update tx cost refresh logic

bisgardo commented 7 months ago

I recommend doing one fix per PR (unless they're closely related). And naming the PR by the actual changes, not the version to be released. The description should also explain the changes (high level), not just reference the tasks (that requires you to do extra work when auditing, but most importantly, Jira is not public so outsiders have no way to follow). Btw. some of the task links in the current description reference Jira tasks, others Git commits.

Doing that is a bit more work, but will give you better reviews, better ability to bisect bugs later on, and better ability to understand why changes were done the way they were in the past.

ramakser commented 7 months ago

I recommend doing one fix per PR (unless they're closely related). And naming the PR by the actual changes, not the version to be released. The description should also explain the changes (high level), not just reference the tasks (that requires you to do extra work when auditing, but most importantly, Jira is not public so outsiders have no way to follow). Btw. some of the task links in the current description reference Jira tasks, others Git commits.

Doing that is a bit more work, but will give you better reviews, better ability to bisect bugs later on, and better ability to understand why changes were done the way they were in the past.

100% true. most fixes was done in send funds flow, so I have combine them in one pr. and then I have merged them with cis2 fixes, so I have no other choice rather than create abstract release brach 😔

next pr's will be as you write before for sure 🥹