Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain
Apache License 2.0
11 stars 10 forks source link

Update text shown in failed identity issuance dialog and e-mail #65

Closed concordium-cl closed 2 years ago

concordium-cl commented 3 years ago

Description The text shown in the dialog when identity issuance fails in the mobile wallet should be updated a bit.

When an e-mail client is found, the text should now mention that Concordium is also added to CC. If an e-mail client is not found, it should be added that Concordium can optionally be added to CC. Additionally, when an e-client is not found, the manual copy function, should copy the full text that would have automatically entered in the e-mail.

The text added to the automatically generated e-mails should also be updated to include a bit more info, like app version and which OS the app is running. iOS / Android should be enough, but if possible the specific OS version would be nice as well.

The change can be seen in Figma in flow 21. The semi transparent pages does not have any changes.

jens-concordium commented 3 years ago

@concordium-cl @kristiyandobrev

This is almost updated as intended in 1.0(19). I've found two small things:

  1. The app version shown in the auto-filled e-mail does not include build number, so it just says 1.0 - Do you know if it's possible to include build number as well, @kristiyandobrev? It is shown in the "About" tab on the "More" page, so I guess it's available somewhere.

  2. When no e-mail client is available, the "Copy reference" option on the dialog still only copies the reference. It should copy the full text, that is now autofilled in the e-mail, when a client is available. I'm sorry if this wasn't clear from the issue text above, and I've also tried to make it a bit clearer in the Figma flow.

Bargsteen commented 3 years ago

This is almost fixed now, but I found two issues:

The text on the Try again and Contract support is wrong.

When I open the email in my client (Spark), the newlines are gone. I guess we could live with it, but it is not as easy to read as the version you copy when clicking Copy reference.

The newlines are included when you view a failed identity and click on the small copy icon.

kristiyandobrev commented 2 years ago

@Bargsteen

I cannot reproduce the issue with the new lines. This is how it looks when I paste it to iMessage:

Screenshot 2021-10-25 at 11 07 20

Can you try out the same ? Perhaps Spark trims the empty lines 🙄

PS:

Actually seems to work fine on Spark too: IMG_A439FFCCBC01-1

Bargsteen commented 2 years ago

The newlines are included when manually copying for me as well. The problem is only present when I click the Contact support button and it opens up in my email client (Spark). @kristiyandobrev

kristiyandobrev commented 2 years ago

@Bargsteen

Right, now I am able to reproduce it. Well, it seems like Spark trims the empty lines when being launched, just as I assumed. For comparison Outlook, Apple Mail or Gmail don't trim. Not much we can do on our side 🤷🏻‍♂️

Bargsteen commented 2 years ago

@kristiyandobrev Okay, if it's just in Spark, then it's fine 😊

jens-concordium commented 2 years ago

Verified in 1.0 (21).