Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain
Apache License 2.0
11 stars 10 forks source link

Finalized shielded transfers with memo are not shown in transfer list #67

Closed concordium-cl closed 3 years ago

concordium-cl commented 3 years ago

Related to task https://github.com/Concordium/concordium-reference-wallet-ios/issues/34

Bug Description 1) When sending a shielded transfer with memo, it shows up in the transfer list for the shielded balance of the sender account while pending. Once when finalized and the view is refreshed, the transfer is not listed anymore.

Note that simple and scheduled transfers with memo are listed, as are shielded transfers without memo.

shielded memo 2

shielded memo 4

2) A shielded transfer with memo is never listed in the transfer list for the shielded balance of the receiver account. It is listed with 0,00 GTU on the unshielded balance of the receiver account.

shielded memo 6

shielded memo 7

Steps to Reproduce

Expected Result

Actual Result The opposite as under expected result.

Versions

kristiyandobrev commented 3 years ago

@concordium-cl

As far as I've been told shielded transfers do not include memos 🤔 Right, @jens-concordium ?

abizjak commented 3 years ago

Normal transfers, shielded transfers, and scheduled transfers all can have memos.

jens-concordium commented 3 years ago

@kristiyandobrev

Yes, as Ales says shielded transfers should include memos, and as I think we discussed, it was transferToSecret and transferToPublic that didn't need any changes.

Actually, it is possible to add memos to shielded transfers as intended, since 1.0(18) I think, the shielded transfers with memos just don't show correctly in the transaction logs as Caro describes.