search

Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain
Apache License 2.0
11 stars 10 forks source link

Transaction fee for encrypted transfer with memo is missing text #68

Closed concordium-cl closed 2 years ago

concordium-cl commented 3 years ago

Related to task https://github.com/Concordium/concordium-reference-wallet-ios/issues/34

Bug Description Transaction fee for encrypted transfer with memo is missing text "Shielded transaction with memo fee" in transfer list.

See below. Transfer at 11:35 is normal encrypted transfer. Transfer at 11:23 is encrypted transfer with memo.

transaction fee text missing - shielded

Steps to Reproduce

Expected Result Explanaition

Actual Result No explanation.

Versions

kristiyandobrev commented 3 years ago

I think https://github.com/Concordium/concordium-reference-wallet-ios/pull/75 fixes that issue.

Bargsteen commented 3 years ago

Tested in 1.0(20).

The description is Shielded transaction fee for transfers with and without a memo. Caro requested the text to be Shielded transaction with memo fee, but I actually think the current fix is better. The user does not need to know that the inclusion of a memo actually causes a different kind of transaction to be sent. The flow in the app does not distinguish between the two. The memo is just shown as an optional addition.

IMG_EF2C9A276C79-1