Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain
Apache License 2.0
11 stars 10 forks source link

Notification on succesful new account #79

Closed jens-concordium closed 2 years ago

jens-concordium commented 2 years ago

Description Currently when an account is finalized, the user is not given any explicit notification. People have been asking for more explicit notifications, and while we cannot push notifications to the OS at the moment, we could show one inside the app after polling the wallet proxy.

This notification could also be used to suggest that people should make a backup after a new account has been added, just to encourage backups more often.

So the suggested change would be:

Sketches showing the change, can be found in Figma.

Versions

jens-concordium commented 2 years ago

@kristiyandobrev @concordium-cl

Single new initial and regular accounts seem to give the notification as intended, but I can't get the "batched" notification to appear. Instead it seems to give an error about not being able to connect to the server. Here's a recording showing the scenario:

https://user-images.githubusercontent.com/76045015/141071255-77382a9a-3790-406a-90a7-96e588ea0a6e.mov

concordium-cl commented 2 years ago

To be tested additionally: Import a wallet with finalized accounts. Observe that there is no "new account "notification dialog shown.

concordium-cl commented 2 years ago

Tested single and multiple account creation and import scenario.

Fixed in 1.0.23.