Support for more identity providers

Concordium / concordium-reference-wallet-ios

Reference wallet for the Concordium blockchain

Apache License 2.0

11 stars 10 forks source link

Support for more identity providers #87

Closed concordium-cl closed 2 years ago

concordium-cl commented 2 years ago

Task description Add support for another identity provider.

Sub-tasks

[ ] change hardcoded contact info in support dialog when id fails (wallet-proxy)
[ ] potential changes to id flow?

jens-concordium commented 2 years ago

@concordium-cl, this looks good to me on iOS 15 in v1.0(25). Even old failed identities work as intended, if they are kept in app through the update to 1.0(25).

concordium-cl commented 2 years ago

@jens-concordium, not sure how to test it atm?

jens-concordium commented 2 years ago

@concordium-cl I just made sure that it still works for Notabene, not much else we can do atm. At least we can tell that the info from the wallet-proxy is presented correctly from Notabene.

You can also make some failed identities in previous versions of the app, and leave them in there while updating to the new version, to see what happens with them.

td202 commented 2 years ago

On the display for a failed identity, it is currently hardcoded with the Notabene info. This is fixed by #122.

jens-concordium commented 2 years ago

@td202, oh so this was not included in the latest build?

concordium-cl commented 2 years ago

Reopened, as new PRs are linked.