search

Concordium / concordium-rosetta

A server implementing the Rosetta API for the Concordium blockchain.
Mozilla Public License 2.0
5 stars 1 forks source link

Upgrade dependencies #39

Closed bisgardo closed 2 years ago

bisgardo commented 2 years ago

Purpose

Ensure that dependencies are up to date.

Changes

Ran cargo update in all projects and pinned versions when the resolved ones were incompatible.

Resolves #36.

bisgardo commented 2 years ago

I am in general opposed to doing these sorts of updates.

In a perfect world people would of course make sure backwards compatibility exists. But we should not be blindly updating without looking at the changelog between the versions.

Many issues can be hidden, and just because it compiles does not mean the semantics stays the same.

I understand, though running unmaintaned software versions is also bad. In an almost as perfect world, unit tests should provide enough confidence that the changes didn't break anything. This project of course doesn't have that at all.

I'm not sure what the proper solution is. Anyway, I did test this manually and it seems good...