search

Concordium / concordium-rosetta

A server implementing the Rosetta API for the Concordium blockchain.
Mozilla Public License 2.0
5 stars 1 forks source link

Migrate structopt to clap v3 #6

Closed bisgardo closed 2 years ago

bisgardo commented 2 years ago

Purpose

As clap v3 is on par with or better than structopt, that project has entered maintenance mode and will not have things like the weird way it handles env vars fixed.

Changes

Upgraded clap to v. 3.1 and removed dependency on structopt.

abizjak commented 2 years ago

Although it also looks like we cannot use clap 3.1 with rust 1.53, so we need to wait with upgrading until we upgrade our toolchains to 1.54+.

bisgardo commented 2 years ago

Although it also looks like we cannot use clap 3.1 with rust 1.53, so we need to wait with upgrading until we upgrade our toolchains to 1.54+.

Building and running with 1.54 works just fine. I'm fine with not merging this until we're upgrading the rest of the toolchain, but this could also serve as a guineapig for the next rust version?

bisgardo commented 2 years ago

@abizjak do you think it's ok to merge now with the bump to 1.54?

abizjak commented 2 years ago

@abizjak do you think it's ok to merge now with the bump to 1.54?

It's not ideal, but if clippy does not produce any new warnings with 1.54 then it is the better option. We'll soon be upgrading the Rust toolchain so it does not make sense to hold this back since it's a new project.

bisgardo commented 2 years ago

@abizjak do you think it's ok to merge now with the bump to 1.54?

It's not ideal, but if clippy does not produce any new warnings with 1.54 then it is the better option. We'll soon be upgrading the Rust toolchain so it does not make sense to hold this back since it's a new project.

Clippy is happy; merging.