Support protocol 7 API changes

Concordium / concordium-rust-sdk

Rust SDK for the Concordium blockchain.

https://docs.rs/concordium-rust-sdk/latest/concordium_rust_sdk/

Mozilla Public License 2.0

13 stars 16 forks source link

Support protocol 7 API changes #198

Closed Victor-N-Suadicani closed 4 months ago

Victor-N-Suadicani commented 5 months ago

Purpose

Addresses https://github.com/Concordium/concordium-rust-sdk/issues/192.

Changes

I updated the concordium-base submodule to point to this commit from this PR which I understand is related to the API changes. This updated the gRPC API submodule in concordium-base, which allowed me to regenerate the protobuf code. I then naively fixed the errors that resulted from the changed generated code.

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

td202 commented 4 months ago

What's currently missing is addressing the changes to PoolInfoResponse. In particular, I'd suggest restructuring BakerPoolStatus to match this. That is, baker_equity_capital, delegated_capital, delegated_capital_cap, pool_info and baker_stake_pending_change are moved into a separate ActiveBakerPoolStatus, which is optional (and should be present if and only if the pool_info is present on the PoolInfoResponse).

Victor-N-Suadicani commented 4 months ago

@td202 I think you should probably merge your PR on base first (https://github.com/Concordium/concordium-base/pull/534) as this depends on that through the submodule.

limemloh commented 4 months ago

Please update the Node version compatibility version in the readme as well

Victor-N-Suadicani commented 4 months ago

@limemloh how do I know which version is the new compatible one?