Concordium / concordium-rust-smart-contracts

Libraries and tools for writing and testing smart contracts on Concordium
https://docs.rs/concordium-std/latest/concordium_std/
Mozilla Public License 2.0
57 stars 35 forks source link

Credential registry template #332

Closed annenkov closed 1 year ago

annenkov commented 1 year ago

Purpose

Add a credential registry template.

The template is a copy of the credential registry example with the following parameters:

The PR also adds tests to the CI for all combinations of restorable and revocable_by_others, and compares the generated contract with the example contract (all parameters are set to true in this case)

The PR also adds upgradability and CIS-0 support to the registry contract example and the template.

Checklist

DOBEN commented 1 year ago

One observation is that the questions are not asked in a particular order, if we can change this behavior in cargo-generate that would be beneficial. This would allow us to have a nicer user flow and implement the above flow (asking more general questions and move on to the more complex questions).

annenkov commented 1 year ago

One observation is that the questions are not asked in a particular order, if we can change this behavior in cargo-generate that would be beneficial. This would allow us to have a nicer user flow and implement the above flow (asking more general questions and move on to the more complex questions).

@DOBEN Yes, this is a good point, I also noticed it. It seems like it's fixed now https://github.com/cargo-generate/cargo-generate/pull/930, but these changes have not been realised yet, because the last release 0.18.3 is from May, and the PR with the fix was merged in July. So, it should fix itself, we just need to wait :)

annenkov commented 1 year ago

The prompt order fix is available in v0.18.4 of cargo-generate now.