Concordium / concordium-rust-smart-contracts

Libraries and tools for writing and testing smart contracts on Concordium
https://docs.rs/concordium-std/latest/concordium_std/
Mozilla Public License 2.0
57 stars 35 forks source link

Fix CI pipeline #394

Closed DOBEN closed 8 months ago

DOBEN commented 8 months ago

Purpose

There are some tests that are currently failing but the CI pipeline does not catch them: https://github.com/Concordium/concordium-rust-smart-contracts/actions/runs/7665712194/job/20892217229

The reason for the pipeline not failing is that there is a bug in cargo-concordium in versions below 3.2.0 related to zero status code returned even if an error occurred. The bug was fixed: https://github.com/Concordium/concordium-smart-contract-tools/blob/main/cargo-concordium/CHANGELOG.md

The CI pipeline currently runs not the up-to-date version of cargo-concordium, which causes the problem.

Changes

DOBEN commented 8 months ago

Version 0.8 fixes the problem, let me check if I can use 0.8.5 (most up-to-date version) as well.

annenkov commented 8 months ago

The version is 0.8 fixes the problem, let me check if I can use 0.8.5 (most up-to-date version) as well.

I thought that we leave the minor version unspecified, unless we are interested in some specific version for some reason. I can see locally that cargo installs the most recent version 0.8.5.