Migrate wallet-proxy to use the node GRPC API V2.

vikt0r0 commented 1 year ago

Purpose

Migrate the client to use the node GRPC API V2.

Depends on https://github.com/Concordium/concordium-client/pull/243

Changes

General

[x] globalInfo (chain parameters) in Main.

Proxy handlers

[x] AccountBalanceR
[x] AccountNonceR
[x] AccountEncryptionKeyR
[x] AccountTransactionsV0R
[x] TransactionCostR
[x] SubmissionStatusR
[x] CredentialR
[x] TransferR
[x] GTUDropR
[x] GlobalFileR
[x] HealthR
[x] AccountTransactionsV1R
[x] BakerPoolR
[x] ChainParametersR
[x] NextPaydayR
[x] PassiveDelegationR
[x] EpochLengthR
[x] CIS2Tokens
[x] CIS2TokenMetadata
[x] CIS2TokenBalance

Handlers that do not need migration

[x] AppSettingsV0
[x] AppSettingsV1
[x] TermsAndConditionsVersion
[x] IpsR
[x] IpsV1R

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

vikt0r0 commented 1 year ago

Should the version be bumped to 0.26?

vikt0r0 commented 1 year ago

Thanks! I resolved the comments, do you want to do the local testing prior to this being merged?

I also planned on doing some tests, especially due to changes introduced post-review - should I still conduct these, or would that perhaps be double the work if you are doing it as well?

abizjak commented 1 year ago

Thanks! I resolved the comments, do you want to do the local testing prior to this being merged?

I also planned on doing some tests, especially due to changes introduced post-review - should I still conduct these, or would that perhaps be double the work if you are doing it as well?

No. Please do the finalization task. Merge this.

abizjak commented 1 year ago

I tested this now compared to the existing one on testnet and mostly the responses agree. However submissionStatus returns a different error code when the transaction type is not supported.

See https://github.com/Concordium/concordium-wallet-proxy/issues/24 which was actually fixed before, but is now reintroduced again.

I made a PR to fix it https://github.com/Concordium/concordium-wallet-proxy/pull/83

Concordium / concordium-wallet-proxy