ignoreCommits set to false, commits not checked? - Githubissues

CondeNast / conventional-pull-request-action

Lint pull requests with the conventional commit spec, for a clean and conventional commit history

Apache License 2.0

15 stars 9 forks source link

ignoreCommits set to false, commits not checked? #24

Open MadeInPierre opened 1 year ago

MadeInPierre commented 1 year ago

Expected Behavior

Hi! I just tried this action with:

rules remained as default
commitTitleMatch to false
ignoreCommits to false

I expect to check if the PR title is correct as well as the commits in the PR.

Actual Behavior

Here is a simple test with empty commits that do not follow the naming convention (but the PR title does). The checks pass:

Isn't it supposed to fail since the commits inside the PR are not valid? Thanks for your help!

Steps to Reproduce the Problem

The attached image is sufficient to reproduce this issue.

sam3k commented 1 year ago

It seems like the intention of this action is to not lint commits if there is more than one commit in the PR. Not sure why; but I was hoping there was an option to lint all commits as well.