CondeNast / launch-vehicle-fbm

An event driven SDK for Facebook Messenger
https://launch-vehicle-fbm.readthedocs.io/en/latest/
Apache License 2.0
13 stars 3 forks source link

Sandbox the tests: move from `sinon.stub` to `sandbox` #59

Closed stripethree closed 7 years ago

stripethree commented 7 years ago

Why are we doing this?

Using sandbox rather than sinon simplifies the afterEach and is also common to our application practices at Condé Nast. Simplifying this small part of the testing setup and teardown process also likely encourages more tests!

Credit to @tswicegood for pointing this out in a comment on #56

closes #57

Did you document your work?

N/A - testing changes only and tests themselves aren't impacted, just the setup and teardown.

How can someone test these changes?

npm i npm t 🎉

What possible risks or adverse effects are there?

None identified.

What are the follow-up tasks?

None identified.

Are there any known issues?

Moving a few things from before to beforeEach could result in a small latency hit but nothing that should be terrible.

Did the test coverage decrease?

Nope!