Settings - Githubissues

CondeNast / purgely

A WordPress plugin to manage Fastly caching behavior and purging.

24 stars 9 forks source link

Settings #21

Closed tollmanz closed 8 years ago

tollmanz commented 8 years ago

This PR adds a settings panel to the Purgely plugin. The settings added to the database will override values configured via constants.

tollmanz commented 8 years ago

Just to keep myself organized, I need to complete the following:

[x] Add settings descriptions
[x] Add better settings page copy
[x] Reorganize the settings page to make things more readable
[x] Implement the settings
[x] Get tests to pass again

simonwistow commented 8 years ago

Let me know if I can help with the copy or anything.

tollmanz commented 8 years ago

Let me know if I can help with the copy or anything.

Hey @simonwistow! I only saw this message after I pushed up descriptions. They are not very good. You probably have a better sense of good ways to describe these settings. Please take a look!

tollmanz commented 8 years ago

@simonwistow I took another, much better pass, at the settings copy. Can you or someone on your team review? If it looks good, I'm ready to merge this!

tollmanz commented 8 years ago

Thanks @simonwistow! I've updated all refs to "stale while error". Best to get this right right now.

Note that this change will revert some users back to the default stale if error behavior, which is turned on and set for 24 hours. I don't imagine that will be too much of a problem.