search

CondeNast / purgely

A WordPress plugin to manage Fastly caching behavior and purging.
24 stars 9 forks source link

Apply filtered Surrogate-Control TTL value #34

Closed dennisroethig closed 4 years ago

dennisroethig commented 7 years ago

Overview

While trying to find a solution to serve different TTLs for different page types I noticed that applied changes to the purgely_surrogate_control filter never make it through to the headers.

Details

Seems like this is a known issue but was never addressed. As we will likely require this functionality in the near future we thought it would make sense to fix that upstream. I'm happy to update/add specs where required if there's an interest in getting this fix merged.

Related issue

https://github.com/CondeNast/purgely/issues/26

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ab822eac42ff3d4357c8170880f0a6911ef20f17 on 99designs:fix-purgely-surrogate-control-filter into 0f48431f8dc47a69cb8e701a710b972807f27e48 on CondeNast:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ab822eac42ff3d4357c8170880f0a6911ef20f17 on 99designs:fix-purgely-surrogate-control-filter into 0f48431f8dc47a69cb8e701a710b972807f27e48 on CondeNast:master.

dennisroethig commented 7 years ago

@tollmanz As you opened https://github.com/CondeNast/purgely/issues/26 do you mind to have a quick look on this and let me know if it's worth moving forward with this or not?

Thanks a lot

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4ba42733813dfa36e83e1bf8384b3e5c96a6f02c on 99designs:fix-purgely-surrogate-control-filter into 0f48431f8dc47a69cb8e701a710b972807f27e48 on CondeNast:master.