search

CondeNast / recipe_plugin

Ziplist Recipe Plugin for Wordpress
http://www.ziplist.com/recipe_plugin
20 stars 13 forks source link

Does not support custom content directory #18

Open derekhubbard opened 10 years ago

derekhubbard commented 10 years ago

I'm using WP-Skeleton (https://github.com/markjaquith/WordPress-Skeleton) in conjunction with WP-Stack (https://github.com/markjaquith/WP-Stack), both of which makes some assumptions on how you have your wordpress environment set up - one of these is the use of a custom content directory.

But, looks like the WP Ziplist plugin doesn't support custom content directories: image

For the most part, it just looks to be some issues with stylesheets not loading successfully.

It looks like there may just be a few references to 'wp-content' to adjust in zlrecipe.php. Any chance someone would be up for modifying to support custom content dirs? image

dcorboy commented 10 years ago

Yes, we'd be happy to consider a code change to support custom content directories. I've just pushed a couple of small changes so everything is up to date now.

Feel free to submit a pull request (or, if you are requesting that we make the changes ourselves, we can discuss that as well).

derekhubbard commented 10 years ago

Thanks. I will submit a pull request and we can go from there. I've been shipping code for awhile, but haven't done much with WP plugin development, so feel free to rip it apart and fire back any suggestions. Glad to help though. :-)

Thanks. Derek

On Wed, Jul 9, 2014 at 12:46 PM, Dave Corboy notifications@github.com wrote:

Yes, we'd be happy to consider a code change to support custom content directories. I've just pushed a couple of small changes so everything is up to date now.

Feel free to submit a pull request (or, if you are requesting that we make the changes ourselves, we can discuss that as well).

— Reply to this email directly or view it on GitHub https://github.com/Ziplist/recipe_plugin/issues/18#issuecomment-48501201 .

dcorboy commented 10 years ago

Sounds good -- I image we simply need to unify all the wp-content references to some global or #define, probably AMD_ZLRECIPE_PLUGIN_VERSION (and then fix that to use the custom content dir).

If you get stuck, just let me know and I can probably find some time to do it. Otherwise, I am happy to review your code once complete.

dcorboy commented 10 years ago

You change is merged. I then went in and cleaned up a bunch of the issues you uncovered. It's almost painfully simple now, but should be equivalent. These changes will come out in version 2.6, but of course you are welcome to use the tip, which is in good shape. Let me know if you have any issues.