search

CondeNast / recipe_plugin

Ziplist Recipe Plugin for Wordpress
http://www.ziplist.com/recipe_plugin
20 stars 13 forks source link

Fix the plugin for WP 3.5 #6

Closed jmargolisvt closed 11 years ago

dcorboy commented 11 years ago

This pull cannot be automatically merged. Jeff I believe we have two of these commits already in the tree. Can you take a look and perhaps isolate the WP 3.5 commit?

jmargolisvt commented 11 years ago

I tried to clean up the commit and force pushed. Didn't think you'd try to merge so quickly! :)

I opened-and-closed a new PR just now in light of your comment about backwards compatibility. That means I should do a bit more work on it. Basically need to make the regex a bit more flexible. I have an older install of WP that I used to help me sniff out the problem. Tomorrow I will test out getting the right regex, reconcile the repos, and push again.

-J

On Wed, Dec 12, 2012 at 10:10 PM, Dave Corboy notifications@github.comwrote:

This pull cannot be automatically merged. Jeff I believe we have two of these commits already in the tree. Can you take a look and perhaps isolate the WP 3.5 commit?

— Reply to this email directly or view it on GitHubhttps://github.com/Ziplist/recipe_plugin/pull/6#issuecomment-11320697.