search

Conduitry / cheap-watch

If it works, why use something else? // Mirror of https://git.chor.date/Conduitry/cheap-watch
https://conduitry.dev/cheap-watch
MIT License
69 stars 4 forks source link

fsevents support #2

Open shellscape opened 5 years ago

shellscape commented 5 years ago

Ahoy. It's been mentioned in a few places (most recently https://github.com/rollup/rollup/issues/2988) that one of the primary benefits of chokidar over cheap-watch is fsevents support, which is natively available on MacOS. The Rollup team is exploring which watching library would be most beneficial to include by default, and while this is by no means a competition, during weighting of directions the lack of fsevents support in cheap-watch did get raised.

I'm curious if supporting fsevents is something you'd be interested in for this lib.

paulocoghi commented 5 years ago

~As a heavy user of cheap-watch (and previously a chokidar user as well), my 2 cents in this case is that cheap-watch works perfectly on all operating systems, incuding MacOS, even not using fsevents, and I don't identify any issues regarding different resource usage.~

shellscape commented 5 years ago

@paulocoghi a user in https://github.com/rollup/rollup/issues/2988 has posted a reproduction and some numbers that seem to indicate that using fsevents on MacOS would be a big boon to performance. I ran the gist provided and can confirm similarities to the numbers. There's a pretty stark difference.

paulocoghi commented 5 years ago

@shellscape , you are right! :)

paulocoghi commented 3 years ago

Edited my first comment. I was wrong, initially, and I recognize using fsevents on MacOS helps using less memory and provides better performance.