ConfettiFX / The-Forge

The Forge Cross-Platform Rendering Framework PC Windows, Steamdeck (native), Ray Tracing, macOS / iOS, Android, XBOX, PS4, PS5, Switch, Quest 2
Apache License 2.0
4.75k stars 497 forks source link

missing getRow in vulkan.h and mental.h #236

Closed yaoyao-cn closed 2 years ago

yaoyao-cn commented 2 years ago

compared with d3d implementation, the following function is missing vec4 getRow(in float4x4 M, uint i) https://github.com/ConfettiFX/The-Forge/blob/master/Common_3/Tools/ForgeShadingLanguage/includes/vulkan.h#L466 https://github.com/ConfettiFX/The-Forge/blob/master/Common_3/Tools/ForgeShadingLanguage/includes/metal.h#L199

and there is no setRow function I use the vector * matrix pattern, For some reason i need to manipulate the 3rd row(the translation component), it will be very convenient if setRow exists

thanks !