search

ConfettiFX / The-Forge

The Forge Cross-Platform Rendering Framework PC Windows, Steamdeck (native), Ray Tracing, macOS / iOS, Android, XBOX, PS4, PS5, Switch, Quest 2
Apache License 2.0
4.63k stars 487 forks source link

DirectX11 bug using debug markers #264

Closed Hochheilige closed 1 year ago

Hochheilige commented 1 year ago

When I'd like to use cmdBeginDebugMarker with DirectX11 renderer the error occured. I found out that this error was just small bug in DirectX11 renderer functions where instead of pCmd->pRenderer->mD3D11.pUserDefinedAnnotation->EndEvent(); there was a pCmd->pRenderer->pUserDefinedAnnotation->EndEvent(); call.

So the error was because pUserDefinedAnnotation is not a part of Renderer itself but the part of pRenderer->mD3D11 struct

wolfgangfengel commented 1 year ago

Thanks for contributing the fix. We develop on an internal GitLab server. We do not accept merge requests here because otherwise, the development and release code base would drift apart. Let me know if you want to become part of our internal GitLab server and you can contribute the code there.

Hochheilige commented 1 year ago

@wolfgangfengel Thank you! I'd like to become part of your GitLab server

wolfgangfengel commented 1 year ago

can you send me an e-mail please.