ConfusedKarma / CTRL

GNU General Public License v3.0
2 stars 7 forks source link

replace get_emoji_regexp() with replace_emoji #18

Closed xbinner18 closed 2 years ago

xbinner18 commented 2 years ago

Emoji wapper removed regex support in 2.0 Fixed markdown parse for saving notes and filters

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 12.39 🙂 12.39 🙂 0.00
Method Length 84.46 🙂 84.38 🙂 -0.08 👍
Working memory 9.84 🙂 9.82 🙂 -0.02 👍
Quality 58.33% 🙂 58.38% 🙂 0.05% 👍
Other metrics Before After Change
Lines 254 254 0
Changed files Quality Before Quality After Quality Change
tg_bot/modules/helper_funcs/string_handling.py 58.33% 🙂 58.38% 🙂 0.05% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tg_bot/modules/helper_funcs/string_handling.py markdown_parser 20 😞 199 😞 17 ⛔ 30.60% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tg_bot/modules/helper_funcs/string_handling.py escape_invalid_curly_brackets 29 😞 140 😞 10 😞 40.63% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tg_bot/modules/helper_funcs/string_handling.py extract_time 9 🙂 126 😞 14 😞 50.24% 🙂 Try splitting into smaller methods. Extract out complex expressions
tg_bot/modules/helper_funcs/string_handling.py button_markdown_parser 8 ⭐ 136 😞 10 😞 56.62% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!