search

ConfusedPolarBear / intro-skipper

Fingerprint audio to automatically detect and skip intro sequences in Jellyfin
GNU General Public License v3.0
988 stars 392 forks source link

Allow autoinjection of ClientSide script #117

Closed JPVenson closed 1 year ago

JPVenson commented 1 year ago

Describe the feature you'd like added An optional function that will inject a script tag into the viewer page to allow a one click Implementation without replacing all source files. This can be toggled on/off as an option and will add the script to the viewer.

Additional context The Jellyscrub plugin does exactly this to provide preview images for the video progressbar. https://github.com/nicknsy/jellyscrub/blob/main/Nick.Plugin.Jellyscrub/JellyscrubPlugin.cs#L38

Mavyre commented 1 year ago

I may add that Jellyscrub works on applications (Android, iOS, WebOs...)

JoshuaMorley commented 1 year ago

I have just had a look at integrating this but it looks like it has already been implemented since November. We are just waiting for it to be added to a future release: https://github.com/ConfusedPolarBear/intro-skipper/blob/master/ConfusedPolarBear.Plugin.IntroSkipper/Plugin.cs#L79-L79

Mavyre commented 1 year ago

I saw it too. However, didn't had time to test it yet

ConfusedPolarBear commented 1 year ago

Closing as this has been implemented in f4e84d4 and will be released in the next version.