search

ConfusedPolarBear / intro-skipper

Fingerprint audio to automatically detect and skip intro sequences in Jellyfin
GNU General Public License v3.0
984 stars 363 forks source link

v10.8.10 #156

Closed aleksasiriski closed 1 year ago

aleksasiriski commented 1 year ago

Please update to v10.8.10

roib20 commented 1 year ago

My current PR #157 addresses GHSA-9p5f-5x8v-x65m of jellyfin/jellyfin. However the web interface fork for intro-skipper also needs to be updated to 10.8.10, in order to address GHSA-89hp-h43h-r5pq of jellyfin/jellyfin-web.

AlexanderBabel commented 1 year ago

In the mean time, I can offer you guys a custom docker image, that builds the vanilla jellyfin-web repo and applies the intro changes through a patch that is dynamically obtained.

The image is hosted at alexbabel/jellyfin:10.8.10-1-ls209 and ghcr.io/alexanderbabel/jellyfin:10.8.10-1-ls209.

The source is documented here. The image uses linuxserver's image as the base.

roib20 commented 1 year ago

Good work @AlexanderBabel. If you tested the changes perhaps consider making a PR for the web interface fork for intro-skipper?

For users, I will note that because alexbabel/jellyfin container image is based on linuxserver/jellyfin (instead of official jellyfin/jellyfin) it is not a drop-in replacement for anyone currently using ghcr.io/confusedpolarbear/jellyfin-intro-skipper. Regardless, it is highly recommended to make backups whenever switching container images.

roib20 commented 1 year ago

Alright I just saw that @ConfusedPolarBear made all the necessary changes today to fully update jellyfin-intro-skipper to v10.8.10 – including the container image and web UI.

The relevant commits are:

Users can now update jellyfin-intro-skipper container image to the following tag: ghcr.io/confusedpolarbear/jellyfin-intro-skipper:10.8.10. The latest tag also currently points to 10.8.10.

My understanding is this issue is now solved and can be closed.