ConfusedPolarBear / intro-skipper

Fingerprint audio to automatically detect and skip intro sequences in Jellyfin
GNU General Public License v3.0
988 stars 407 forks source link

Inject into web at runtime #194

Open Ruakij opened 1 year ago

Ruakij commented 1 year ago

Describe the feature you'd like added Instead of using a custom web-interface it would be alot easier and more compatible if instead the necessary assets are injected at runtime by the plugin.

I dont know what is necessary or how exactly it works, but e.g. https://github.com/nicknsy/jellyscrub supports it and injects their timeline-images into the web-client like that. image

svenons commented 1 year ago

Do you, by chance, still have the custom webfiles? It looks like the last build from 4 months ago has those files expired.

Ruakij commented 1 year ago

Do you, by chance, still have the custom webfiles? It looks like the last build from 4 months ago has those files expired.

Have a look at https://github.com/ConfusedPolarBear/intro-skipper/issues/189

I have also compared the files with the original jellyfin web ones, but am not sure how and when things have to be loaded.

svenons commented 1 year ago

Thank you so much, @Ruakij! ;)

Dysta commented 1 year ago

Ig its possible since we just have to extract the commit from https://github.com/ConfusedPolarBear/jellyfin-web/commits/intros?author=ConfusedPolarBear and add those in a custom .js like Jellyscrub does

iluvatyr commented 1 year ago

I think it would be actually important to implement it this way so that both plugins can coexist. I cannot run jellyscrub and this plugin at the same time since the webinterface is mounted as readonly when using this.

ovosimpatico commented 1 year ago

I think it would be actually important to implement it this way so that both plugins can coexist. I cannot run jellyscrub and this plugin at the same time since the webinterface is mounted as readonly when using this.

It's possible to use both, just change :ro to :rw on docker compose, mounting it as read/write.

Both are working fine here with this change.