ConfusedPolarBear / intro-skipper

Fingerprint audio to automatically detect and skip intro sequences in Jellyfin
GNU General Public License v3.0
986 stars 414 forks source link

Open Discussion on Plugin Integration #53

Open anthonylavado opened 2 years ago

anthonylavado commented 2 years ago

đź‘‹ Hi! I'm Anthony from the Jellyfin Core Team. As the plugin is getting to be more popular, we'd like to talk a bit about how we can best support you, or even bring the plugin/web changes to be part of the project.

Would you be interested in joining our chat to discuss this further? We're primarily on Matrix, but you can join via Discord too. One note is that if you join via Discord, then we wouldn't be able to DM/etc.

Our contact links are all here: https://jellyfin.org/contact/

Edit: I see you're in some of the rooms already! Send me a ping whenever you're around.

sourpatched commented 2 years ago

@anthonylavado @ConfusedPolarBear As I big fan of Jellyfin and now a fan of this project like many other people. Can we have an update on this Open Discussion?

60+ people are keen for more.

anthonylavado commented 2 years ago

@sourpatched Sure. A few points.

Together:

Longer-Term Jellyfin side:

This is all very high level still. If we're talking about when changes would be visible, it would be 10.9 at the earliest. Once a release number (e.g. 10.8) goes out, any maintenance releases (e.g. 10.8.1) are bug fixes. No new features. The main project is working on better build systems and we're hoping to make faster releases with it.

Sorry if it's not the answer you were hoping to hear just yet, but we're working on it 🤠

sourpatched commented 2 years ago

@anthonylavado This is welcoming news! I am already excited for 10.9 and beyond! Thank you for the detailed response.

Is this going to be apart of the jellyfin family? of cause @ConfusedPolarBear get credited.

I came from Plex and ended up finding Jellyfin years ago, since then I have never looked back as Jellyfin is a one of a kind community.

06kellyjac commented 2 years ago

A way for plugins to modify the web interface would be super powerful :rocket:

MagicTrevor commented 2 years ago

Definitely appreciate the support the team is giving and planning to give to plugins like this as well as future ones. Looking forward to the better integration!

anthonylavado commented 2 years ago

@ConfusedPolarBear We're beginning discussions over what segment skipping would look like. You can see the discussion here: https://github.com/jellyfin/jellyfin-meta/discussions/30


To all other interested parties/fans:

I would ask that you refrain from commenting unless you have a technical reason/comment. If you just want to show your support, feel free to leave reactions/upvotes. If updates are what you're after, there is a subscribe button at the bottom of the discussion. Posting extra comments always sends messages to more people that you think it does - this conversation here has four participants, but dozens of people that get an e-mail/ping.

However, thank you for your support. We love Jellyfin as much as you all do and we want to keep pushing it forward.

Ge082 commented 1 year ago

For outro skipping (if it is still in the planning phase), the simplest solution is to take advantage of the "up next / continue watching" feature, if audio fingerprint / image match an outro then trigger the "up next" poppup seconds before or just when the credits starts, else use the default "up next" timer. Because it's already a good addition to Jellyfin, why not improve it in a smarter way if the Intro Skipper plugin gets natively integrated within Jellyfin

JVT038 commented 1 year ago

For outro skipping (if it is still in the planning phase), the simplest solution is to take advantage of the "up next / continue watching" feature, if audio fingerprint / image match an outro then trigger the "up next" poppup seconds before or just when the credits starts, else use the default "up next" timer.

Some movies and shows (like Marvel movies and the Star Wars show 'Andor') have a post-credit scene. If you were to just continue to the next episode / movie, then this post-credit scene would be skipped. I think it would be better to skip the credits instead and continue to the post-credit scene. Or maybe it can detect whether a post-credit scene exists, and show 'up next' if there is no post-credit scene. But if there is a post-credit scene, it should show 'skip credits'.

Plex has recently introduced a skip credits feature, which does the same I mentioned above. From Plex:

When playing content in a supported app, a “Skip Credits” button will appear when the credits start. This is overlaid on the video, allowing you to select it to skip the credits. If extra scenes during or after the credits were detected, then playback will skip to those