search

Confuser2188 / PhoenixAntiCheat

An anti-cheat plugin for Bukkit/Spigot
1 stars 3 forks source link

Phase/Noclip does not account for collisionless blocks #25

Open ghost opened 5 years ago

ghost commented 5 years ago

General Information

PAC version : 2.0.0-pre6

Server version : 1.13.2 Paper

Plugin list : PAC

Explanation of issue

Phase/Noclip does not account for blocks with either no collision or blocks with irregular bounds, including falling gravel, torches, anvils, and potentially others. This causes players to get stuck in blocks whilst playing legitimately.

I would propose you implement a block whitelist in the config, alongside whatever you are hard coding, so admins can fix this issue manually.

6 #23, assumably #7 too

Jan 23 13:24:39 ncraft.org java[4664]: [13:24:39 INFO]: PAC: Sage64 failed Phase check [VL: 19] [Ping: 79] [Info: type:'edge' block:'WALL_TORCH']

zedwick commented 5 years ago

Would like to add STRUCTURE_VOID to the list of collision-less blocks affected by phase (and flight if above it).

Wall signs appear to only sometimes be affected by phase check, in the one instance I am aware of you cannot walk into or out of the wall sign block from the opposite edge to the side with the wall sign, but can pass through the other two sides (the fourth, with the wall sign on it, has a block so I didn't test with my vanilla client). As signs don't have collision, this probably doesn't matter anyway; just seems it can get the bounding box in the wrong position for some reason.

dwaynehulsman commented 5 years ago

Please whitelist WALL_SIGN as well.