search

Confusezius / ECCV2020_DiVA_MultiFeature_DML

(ECCV 2020) This repo contains code for "DiVA: Diverse Visual Feature Aggregation for Deep Metric Learning" (https://arxiv.org/abs/2004.13458), which extends vanilla DML with auxiliary and self-supervised features.
34 stars 11 forks source link

Is ECCV2020_DiVA_MultiFeature_DML/evaluation/evaluate.py used? #5

Closed Wang-Wenqing closed 2 years ago

Wang-Wenqing commented 2 years ago

Hi, I have some confusion about evaluation/evaluate.py, firstly, there is a function (as followed) not defined in this project, while I found this function in another project of yours, and secondly, when I debug it, I found it directly in evaluation/init.py and not jump into evaluation/evaluate.py, so is it a mistake putting or I miss something?

https://github.com/Confusezius/ECCV2020_DiVA_MultiFeature_DML/blob/7b9131767a33d67acb19d4753e4b54a5ed0b78b0/evaluation/evaluate.py#L13

https://github.com/Confusezius/ECCV2020_DiVA_MultiFeature_DML/blob/7b9131767a33d67acb19d4753e4b54a5ed0b78b0/evaluation/evaluate.py#L66

Confusezius commented 2 years ago

Thanks for pointing that out! evaluation/evaluate.py is indeed an obsolete script that is not used; all the evaluation functions are in evaluation/__init__.py. I'll remove evaluation/evaluate.py to make that clear :).