ElRandom78
commented
2 months ago To be sure of one thing , I ask you directly: The "Missing item names" visualization message which we talked about before, must be generated by the algorithm in which cases? Only when a model isn't available anymore on the site or also in other cases for other reasons?
Confuzu
Hi,
it seems that something doesn't work properly with these calculation functions:
Downloaded items for username:...'andMissing items for username:...'This is my try of a download:
you can see the issue right away, in the first block of 100 items: -Total items that has to be downloaded in the 1° block is 100 since like pagination proceed in this way. -'Downloaded items' I interpret it as 'the actual real number of downloaded items that the algorythm has downloaded successfully (=where "ITEMS' are CIVITAI folders, where each one of them can contain one or more files). If the number of downloaded items is 100, the number of missing items can't be 100. It Must be 0. The same way, for the last pagination block : if in the last block there are a total of 8 items, and the algorithm has downloaded succesfully 8 items, the number of Missing items must be 0.
Maybe something doesn't work properly between len() function and set() function, but I'm not sure.
In my opinion, this incongruency is caused by the presence of multiple folders that share the same names on CIVITAI. I've chosen nochekaiser881 as example because it suits perfectly for this explanation,
take his Yor Briar files as examples : https://civitai.com/models/117016/yor-briar-yor-forger-spy-x-family https://civitai.com/models/324788/yor-briar-yor-forger-spy-x-family https://civitai.com/models/342830/yor-briar-yor-forger-spy-x-family https://civitai.com/models/99975/yor-briar-yor-forger-spy-x-family-commission-w-dataset
Following the algorithm logic, the three folder are downloaded as one, with 8 files inside, and one folder is created apart (because has a different name) with 4 files inside. Thats's ok but in my opinion this can generate confusion in the function that count the number of items downloaded/missed.
Maybe, to overcome this issue, must be found a way to attribute a unique index to each folder ; in this way the algorithm can recognize and count each one of them independently.
The other issue is about 'Missing items printed list':
but file named 'Kimihiko' is not missed, has been downloaded like below:
I also checked, because in my numerous tries It happened that this 'missing item' printed message was showed when there was a specific version missed of 1 file, but this is not the case, because as you can see on the site, there is only 1 version available for this file
https://civitai.com/models/335061/kimihiko-assistant-singularity-watson-kimizuka-the-detective-is-already-dead-tantei-wa-mou-shindeiru
, so there must be something that trigger unproperly this message.