search

Congyuwang / RocksDict

Python fast on-disk dictionary / RocksDB & SpeeDB Python binding
https://congyuwang.github.io/RocksDict/rocksdict.html
MIT License
173 stars 8 forks source link

Allow threads on closes and cleanup functions #104

Closed GodTamIt closed 8 months ago

GodTamIt commented 8 months ago

These functions can induce a decent amount of I/O and take a while, so allowing threading on them is reasonable here.

GodTamIt commented 8 months ago

@Congyuwang FYI that I've made https://github.com/rust-rocksdb/rust-rocksdb/pull/849 upstream so we can drop the GIL for compaction as well.

Congyuwang commented 8 months ago

@Congyuwang FYI that I've made rust-rocksdb/rust-rocksdb#849 upstream so we can drop the GIL for compaction as well.

Good. I would merge this PR into rust-rocksdb/rocksdict later.

Congyuwang commented 8 months ago

@GodTamIt Upstream commits merged into tag: v0.23.0+8.9.1.