search

Congyuwang / RocksDict

Python fast on-disk dictionary / RocksDB & SpeeDB Python binding
https://congyuwang.github.io/RocksDict/rocksdict.html
MIT License
173 stars 8 forks source link

Support for Linux/aarm64 #85

Closed martinffx closed 10 months ago

martinffx commented 10 months ago

Is it possible to add support for Linux/aarm64?

#0 134.5   • Installing rocksdict (0.3.15)
#0 134.6 
#0 134.6   RuntimeError
#0 134.6 
#0 134.6   Unable to find installation candidates for rocksdict (0.3.15)

Happy to work on a PR, if you point me in the right direction.

Congyuwang commented 10 months ago

I think I have a linux/Aarch64 build, manylinux_2_28, which requires 'pip >= 20.3'. Can you try running 'pip --version'? Also you might try 'pip install --upgrade pip'.

martinffx commented 10 months ago

I'm using poetry 1.6.1 on alpine, let me try it with pip.

martinffx commented 10 months ago

Okay, the issue is alpine linux:

FROM python:3.11-alpine as base

RUN pip install --upgrade pip
RUN pip install rocksdict

that fails

FROM python:3.11-slim as base

RUN pip install --upgrade pip
RUN pip install rocksdict

this works

martinffx commented 10 months ago

I guess the docs don't call out aarm64 support on linux but do on other platforms

This package is built for macOS (x86/arm), Windows 64/32, and Linux x86. It can be installed from pypi with pip install rocksdict.

https://congyuwang.github.io/RocksDict/rocksdict.html

Congyuwang commented 10 months ago

Thanks. I’ll update the readme.